Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust console logging; set editing prefs #36

Merged
merged 2 commits into from Aug 6, 2016

Conversation

devoncarew
Copy link
Contributor

  • specify to use tabs w/ the project
  • add a flag to control analysis server traffic logging
  • minor tweaks to the logging

Some of the changes are more style related; happy to iterate on this patch.

@@ -1,5 +1,7 @@
// Place your settings in this file to overwrite default and user settings.
{
"editor.tabSize": 4,
"editor.insertSpaces": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just noticed there was a weird mismatch in my files.. I think I set insertSpaces: false but the default behaviour scans the existing file and my extension.ts (and somehow util.ts) have spaces.

4-char tabs is my preference and I planned on sorting this

👍 !

@DanTup
Copy link
Member

DanTup commented Aug 6, 2016

All seems fine to me (though I'd prefer to break the ifs onto two lines).

Dumping things to the console was useful when I started, but the debug console in Code is so bad (doesn't show long things, is really sluggish and copy/paste doesn't work properly for more than the visible height) that I'm thinking of changing this to dump to disk. Hopefully there's a way to only do this from the dev extension host; doesn't make much sense on users machines (unless they're trying to help diagnose something).

@DanTup DanTup merged commit 777f508 into Dart-Code:master Aug 6, 2016
@DanTup
Copy link
Member

DanTup commented Aug 6, 2016

Thanks! :)

@devoncarew
Copy link
Contributor Author

that I'm thinking of changing this to dump to disk

You could set up a hidden pref to specify a file to log to (dart.development.serverLog) - that way you could log during development but it wouldn't be something that's exposed to users -

@DanTup
Copy link
Member

DanTup commented Aug 6, 2016

Does Code support hidden config options? I get completion suggestions on the others, haven't seen anything about hiding them. Sounds like a good option if there is. I've created #37 as a task to figure something out.

@devoncarew
Copy link
Contributor Author

If you define them in package.json they'll show up in that overall, synthesized settings file. I think you can read from any value though, so reading from dart.fooBar but not listing it in the package spec should effectively create a hidden pref.

@DanTup
Copy link
Member

DanTup commented Aug 6, 2016

Gotcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants