-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust console logging; set editing prefs #36
Conversation
@@ -1,5 +1,7 @@ | |||
// Place your settings in this file to overwrite default and user settings. | |||
{ | |||
"editor.tabSize": 4, | |||
"editor.insertSpaces": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually just noticed there was a weird mismatch in my files.. I think I set insertSpaces: false
but the default behaviour scans the existing file and my extension.ts
(and somehow util.ts
) have spaces.
4-char tabs is my preference and I planned on sorting this
👍 !
All seems fine to me (though I'd prefer to break the ifs onto two lines). Dumping things to the console was useful when I started, but the debug console in Code is so bad (doesn't show long things, is really sluggish and copy/paste doesn't work properly for more than the visible height) that I'm thinking of changing this to dump to disk. Hopefully there's a way to only do this from the dev extension host; doesn't make much sense on users machines (unless they're trying to help diagnose something). |
Thanks! :) |
You could set up a hidden pref to specify a file to log to ( |
Does Code support hidden config options? I get completion suggestions on the others, haven't seen anything about hiding them. Sounds like a good option if there is. I've created #37 as a task to figure something out. |
If you define them in package.json they'll show up in that overall, synthesized settings file. I think you can read from any value though, so reading from |
Gotcha! |
Some of the changes are more style related; happy to iterate on this patch.