Merge pull request #234 from DarthAffe/SmallImprovements

Small improvements
DarthAffe · Sep 5, 2021 · fab2c15 · fab2c15
2 parents e645e4d + d487bee
commit fab2c15
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/RGB.NET.Core/Decorators/AbstractDecorateable.cs b/RGB.NET.Core/Decorators/AbstractDecorateable.cs
@@ -14,13 +14,18 @@ public abstract class AbstractDecoratable<T> : AbstractBindable, IDecoratable<T>
         private readonly List<T> _decorators = new();
 
         /// <inheritdoc />
-        public IReadOnlyCollection<T> Decorators
+        public IReadOnlyCollection<T> Decorators { get; }
+
+        #endregion
+
+        #region Constructors
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="AbstractDecoratable{T}"/> class.
+        /// </summary>
+        protected AbstractDecoratable()
         {
-            get
-            {
-                lock (_decorators)
-                    return new ReadOnlyCollection<T>(_decorators);
-            }
+            Decorators = new ReadOnlyCollection<T>(_decorators);
         }
 
         #endregion

diff --git a/RGB.NET.Devices.DMX/E131/E131DeviceInfo.cs b/RGB.NET.Devices.DMX/E131/E131DeviceInfo.cs
@@ -68,15 +68,15 @@ internal E131DeviceInfo(E131DMXDeviceDefinition deviceDefinition)
             this.Hostname = deviceDefinition.Hostname;
             this.Port = deviceDefinition.Port;
             this.Universe = deviceDefinition.Universe;
-            
+
             byte[]? cid = deviceDefinition.CID;
             if ((cid == null) || (cid.Length != CID_LENGTH))
             {
                 cid = new byte[CID_LENGTH];
                 new Random().NextBytes(cid);
             }
 
-            CID = cid!;
+            CID = cid;
 
             DeviceName = DeviceHelper.CreateDeviceName(Manufacturer, Model);
         }