Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added physical-layout to KeyboardDeviceInfo #174

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

DarthAffe
Copy link
Owner

No description provided.

@DarthAffe
Copy link
Owner Author

@SpoinkyNL Does this fit what you requested?

@RobertBeekman
Copy link
Collaborator

I have some extra types here

https://github.com/Artemis-RGB/Artemis.Plugins/blob/03e3c3f0016c361810bf02be5ac92481a2d32a22/src/Devices/Artemis.Plugins.Devices.Corsair/CorsairDeviceProvider.cs#L34

Other than that, in Artemis I also use a two letter country code for logical layout but perhaps thats too implementation-specific/opinionated for RGB.NET

@DarthAffe DarthAffe merged commit 0e30c93 into Development Feb 20, 2021
@DarthAffe DarthAffe deleted the Core/DeviceHandling branch February 20, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants