model binding fixes uncovered doing integration with Surgery Logistic…

…s system
DarthFubuMVC · Apr 9, 2012 · c5d4b9a · c5d4b9a
1 parent a093716
commit c5d4b9a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/FubuCore/Binding/ArrayPropertyBinder.cs b/src/FubuCore/Binding/ArrayPropertyBinder.cs
@@ -43,6 +43,10 @@ public class ArrayBuilder<T> : IArrayBuilder
             public void FillValues(PropertyInfo property, IBindingContext context)
             {
                 var requests = context.GetEnumerableRequests(property.Name).ToList();
+
+                // TODO -- need an end to end test on this behavior 
+                if (!requests.Any()) return;
+
                 var data = new T[requests.Count];
 
                 for (int i = 0; i < requests.Count; i++)

diff --git a/src/FubuCore/Binding/InMemory/RecordingBindingLogger.cs b/src/FubuCore/Binding/InMemory/RecordingBindingLogger.cs
@@ -91,7 +91,7 @@ public void UsedValue(BindingValue value)
         {
             if (_models.Any())
             {
-                currentReport.LastProperty.Used(value);
+                currentReport.Used(value);
             }
         }
 

diff --git a/src/FubuCore/Binding/Logging/BindingReport.cs b/src/FubuCore/Binding/Logging/BindingReport.cs
@@ -94,5 +94,14 @@ public PropertyBindingReport For<T>(Expression<Func<T, object>> expression)
             var property = expression.ToAccessor().InnerProperty;
             return For(property);
         }
+
+        // TODO -- what if Value() is used outside the context of a property?
+        public void Used(BindingValue value)
+        {
+            if (_properties.Any())
+            {
+                LastProperty.Used(value);
+            }
+        }
     }
 }