remove getIsOnDemand function : not used.

In my opinion, if a function is only used in test unit file, it has to be deleted.
Dash-Industry-Forum · Jun 9, 2017 · 9d3a48c · 9d3a48c
1 parent f25a8ef
commit 9d3a48c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/src/dash/models/DashManifestModel.js b/src/dash/models/DashManifestModel.js
@@ -289,10 +289,6 @@ function DashManifestModel() {
         return has;
     }
 
-    function getIsOnDemand(manifest) {
-        return hasProfile(manifest, 'urn:mpeg:dash:profile:isoff-on-demand:2011');
-    }
-
     function getIsDVB(manifest) {
         return hasProfile(manifest, 'urn:dvb:dash:profile:dvb-dash:2014');
     }
@@ -895,7 +891,6 @@ function DashManifestModel() {
         getKID: getKID,
         getContentProtectionData: getContentProtectionData,
         getIsDynamic: getIsDynamic,
-        getIsOnDemand: getIsOnDemand,
         getIsDVB: getIsDVB,
         getDuration: getDuration,
         getBandwidth: getBandwidth,

diff --git a/test/unit/dash.DashManifestModel.js b/test/unit/dash.DashManifestModel.js
@@ -30,17 +30,7 @@ describe('DashManifestModel', function () {
         const isDVB = dashManifestModel.getIsDVB(manifest);
 
         expect(isDVB).to.be.false; // jshint ignore:line
-    });
-
-    it('should return true when getIsOnDemand is called and manifest contains the on-demand profile', () => {
-        const manifest = {
-            profiles: 'urn:dvb:dash:profile:dvb-dash:2014,urn:mpeg:dash:profile:isoff-on-demand:2011'
-        };
-
-        const isOnDemand = dashManifestModel.getIsOnDemand(manifest);
-
-        expect(isOnDemand).to.be.true; // jshint ignore:line
-    });
+    });   
 
     it('should return NaN when minimumUpdatePeriod is not present in manifest', () => {
         const manifest = {};