Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MediaElement Controls VideoModel -> PlaybackController #1019

Closed
dsparacio opened this issue Jan 14, 2016 · 1 comment
Closed

Refactor MediaElement Controls VideoModel -> PlaybackController #1019

dsparacio opened this issue Jan 14, 2016 · 1 comment
Assignees
Milestone

Comments

@dsparacio
Copy link
Contributor

Currently we partially implement video element API layer ( play, pause, seek time duration etc... ) in MediaPlayer and this was done for DVR window capabilities. Need to fully implement so a user can just call API and listen to events with one object, MediaPlayer.

Once I started looking at the code I notice we have partial element control in two places internally. I understand why we need to be able to control the element internally but we need to clean this up.

Solution..
Refactor the duplicated / parallel code in VideoModel into PlaybackController as well as add the missing Video Element API layer desired and map all calls to video element in mediaplayer to this controller.

@dsparacio dsparacio self-assigned this Jan 14, 2016
@dsparacio dsparacio added this to the 2.0.0 milestone Jan 14, 2016
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Jan 14, 2016
@dsparacio
Copy link
Contributor Author

Fixed with PR #1020

dsparacio pushed a commit that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant