Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Text fails to add track in Firefox #1040

Closed
dsparacio opened this issue Jan 20, 2016 · 2 comments
Closed

Time Text fails to add track in Firefox #1040

dsparacio opened this issue Jan 20, 2016 · 2 comments
Labels
Bug Pri-Critical
Milestone
2.0.0

Comments

@dsparacio
Copy link
Contributor

Seems we have an issue with adding tracks to video element in firefox blocking any TT from working.

The problem is in addTextTrack in TextTrackExtensions. We are not able to add track directly so addCue fails since there are no tracks on video element when we go to add cues.
@dsparacio
Copy link
Contributor Author

If possible due to issue in Dash.js add to 2.0 milestone. If we find out that it is limitation of browser we will update milestone....

@dsparacio dsparacio added this to the 2.0.0 milestone Jan 20, 2016
@wilaw wilaw mentioned this issue Jan 29, 2016
Closed
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Feb 2, 2016
Fix for Dash-Industry-Forum#1040
51e342d 
Cleaned up user agent logic a bit and tested on Edge Ie11 firefox and chrome.  Text tracks are all working as expected. Cleaning up and reloading as expected.
@dsparacio
Copy link
Contributor Author

Fixed with PR #1107.

dsparacio pushed a commit that referenced this issue Feb 2, 2016
Merge pull request #1107 from AkamaiDASH/development
ad1c6fb 
Fix for #1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Pri-Critical
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@dsparacio