Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferTarget is not correct with regards to live delay and live streams #1110

Closed
dsparacio opened this issue Feb 2, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@dsparacio
Copy link
Contributor

If we have a hold back of 24 seconds we should be building at least same stable buffer as VOD

if (!isDynamic && abrController.isPlayingAtTopQuality(streamInfo)) {//TODO || allow larger buffer targets if we stabilize on a non top quality for more than 30 seconds.
bufferTarget = isLongFormContent ? mediaPlayerModel.getBufferTimeAtTopQualityLongForm() : mediaPlayerModel.getBufferTimeAtTopQuality();
}else if (!isDynamic) {
//General VOD target non top quality and not stabilized on a given quality.
bufferTarget = mediaPlayerModel.getStableBufferTime();
} else {
bufferTarget = playbackController.getLiveDelay();
}

@dsparacio dsparacio self-assigned this Feb 2, 2016
@dsparacio dsparacio added this to the 2.0.0 milestone Feb 2, 2016
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Feb 4, 2016
@dsparacio
Copy link
Contributor Author

Fixed in PR #1117

dsparacio pushed a commit that referenced this issue Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant