resetAndIntializePlayback method not robust after a failed playback

[wilaw]

If an attempt is made to play a manifest which results in a media decode error, the subsequent call to resetAndIntializePlayback() on mediaplayer results in the callstack error described by the attached image.

[dsparacio]

@wilaw Do you have an MPD that exhibits this behavior?

[wilaw]

http://212.99.93.126:8090/dash_irt/manifest.mpd but may not be up for long.

[dsparacio]

thanks @wilaw i was able to reproduce. Non blocking issue just shows error in reset logic but you can still play a new source file with no issue. This should be addressed in 2.1.

[davemevans]

The problem occurs because streamcontroller resets itself in the case of decode error but not if everything went well. Calling streamcontroller.reset again obviously shouldnt cause an exception so we should put guards around this stuff, but I also wonder whether objects should only be reset by their owner in one place which would mean this problem wouldn't occur anyway.

This is very similar to #1130, where modules can be reset by code which does not own them and they are not robust to multiple reset calls.