Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaPlayer#setTextTrack() call resumes player when paused #1172

Closed
yturtle98 opened this issue Feb 16, 2016 · 3 comments
Closed

MediaPlayer#setTextTrack() call resumes player when paused #1172

yturtle98 opened this issue Feb 16, 2016 · 3 comments
Assignees
@dsparacio
Labels
Bug
Milestone
2.1.0

Comments

@yturtle98
Copy link

While testing one of the samples provided, "multi-track-captions",
I have noticed that changing a caption resumes the player.
Is it intended?
It only occurs for fragmented captions not for external captions.

It seems that switching text tracks leads to "re-initialization" of streams,
which results calling StreamController#startAutoPlay().
@TobbeEdgeware
Copy link

I've noticed this as well. I don't think it is intended.

@dsparacio dsparacio added the Bug label Feb 16, 2016
@dsparacio dsparacio added this to the 2.1.0 milestone Feb 16, 2016
@dsparacio dsparacio self-assigned this Feb 23, 2016
@dsparacio
Copy link
Contributor

Indeed it does. Fixing now. Thanks!

dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Feb 23, 2016
Fix for issue Dash-Industry-Forum#1172
b9c11d6
@dsparacio
Copy link
Contributor

Fixed with PR #1200

dsparacio pushed a commit that referenced this issue Feb 23, 2016
Merge pull request #1200 from AkamaiDASH/development
293bb3d 
Fix for issue #1172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsparacio dsparacio

Labels
Bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@dsparacio @yturtle98 @TobbeEdgeware