Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate loop in schedule controller never stops if scheduleWhilePaused is true #1203

Closed
ghost opened this issue Feb 23, 2016 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Feb 23, 2016

ScheduleController's stop is never called and if we set scheduleWhilePaused as true, validate loop keeps getting called even after stream has completed and finished playing.

Steps to repro (valid both for 1.6.0 and 2.0):

  1. Set scheduleWhilePaused as true using setScheduleWhilePaused API
  2. Play video till end.
  3. If you take a break at validate, it keeps getting called indefinitely.
  4. It works in the hosted dash.js because
    a) scheduleWhilePaused is false
    b) video element goes into paused state after playback completes
    c) so validate returns not because isStopped is true but because playbackController.isPaused() is true and scheduleWhilePaused is false

Expected Behavior: We should call scheduleController stop() in onStreamCompleted

@dsparacio dsparacio added the Bug label Feb 23, 2016
@dsparacio dsparacio added this to the 2.1.0 milestone Feb 23, 2016
@dsparacio dsparacio self-assigned this Feb 23, 2016
@dsparacio
Copy link
Contributor

Any stream or is it specific to Timeline, Template or Base?

@dsparacio
Copy link
Contributor

Nevermind. Found it and easy fix thanks for the solution. Ill test and commit later today.

@dsparacio
Copy link
Contributor

Fixed with PR #1208

dsparacio pushed a commit that referenced this issue Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant