Refactor SegmentBaseLoader to use shared segment loading code

[davemevans]

Recently, all XHR requests for manifests, xlink and 'normal' fragment loading were refactored into a base loader (XHRLoader), with a view to removing duplication and, in future, facilitating alternative transports.

SegmentBaseLoader has always done its own thing for some reason, and it should probably be transitioned to the standard shared code if at all possible. At first glance, it looks like it may be.

This isn't an area I'm familiar with since our streams, and most others I am familiar with use the FragmentLoader. Does anyone have in-depth understanding of SegmentBaseLoader?

[dsparacio]

It's been some time but I did do a bit in that class a while back . We mostly use template as well. What's going on? I think we have some content if you need it.

[davemevans]

I was in there while dealing with baseurl and just noticed that it could do with refactoring when/if anyone has time/inclination. Would label it as a nice to have.

[dsparacio]

gotcha

[davemevans]

I noticed TimeSyncController also has its own XHR code so could be another candidate for refactoring.