Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE only: Ended doesn't seem to fire #1298

Closed
dsparacio opened this issue Apr 1, 2016 · 4 comments
Closed

IE only: Ended doesn't seem to fire #1298

dsparacio opened this issue Apr 1, 2016 · 4 comments
Assignees
Milestone

Comments

@dsparacio
Copy link
Contributor

IE only: Also, Ended doesn't seem to fire? Play button does not re-appear at the end of playback.

@dsparacio dsparacio added this to the 2.1.0 milestone Apr 1, 2016
@dsparacio dsparacio self-assigned this Apr 1, 2016
@dsparacio
Copy link
Contributor Author

Also notice this for Muliperiod content at end of period in all browsers except chrome. May not be related but wanted to add note. Also noted in MP issue #1033

@dsparacio
Copy link
Contributor Author

Seems to just be issue with UI controlbar.js Not listening to right event apparently for Ie will solve. But in IE console I see all the right logs

[87781] Getting the next request at index: 15
[87781] Signal complete.
[87781] Schedule controller stopping for video
[87782] Stream is complete
[117499] Native video element event: ended

@dsparacio
Copy link
Contributor Author

[Only with IE] the pause state not set at end of stream. So I manually do this to ensure event. Seems like right behavior beyond the contrib control bar needs isPaused true when toggling the icon as well as needs either ended or paused event.

It works well and solves the issue while maintaining other browser's event order at end of stream. In fact this levels the playing field so all browsers now see pause event followed by ended event.

@dsparacio
Copy link
Contributor Author

Github is having push issues right now. Pushed to upstream, one line change no PR. moving on.

dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Apr 5, 2016
Added call to playbackcontroller’s pause method in onend. Ensure pause state at end of stream.  Test all browsers on win and mac. Tested MP content - all Works well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant