-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DASH-IF player cannot properly render ttml with multiple lines #1340
Comments
dash.js certainly can render multi-line TTML:
However, the TTML parser in dash.js was originally designed as an EBU-TT-D [1] parser which means its only supports a constrained subset of TTML. I assume something in your TTML does not meet these constraints. |
Can you give us access to the TTML content? [Update: I see that it's visible in the zip file] |
Hi Nigel, The generated dash content is already attached and submitted with the ticket. Please review. We are pretty sure the content conforms to specification, just the decoder has some limitations in properly rendering the ttml. Please advise. Many thanks. Best regards,
|
Thanks Ryan, I've found it. It certainly is non-compliant against EBU-TT-D and doesn't validate against the schema, and this is related to the symptom in this case. The TTML here defines region style attributes on a This is an area where EBU-TT-D is stricter than TTML; this syntactical approach (of referencing style elements from a region and putting region-applicable style elements in those style elements) is permitted in TTML. Arguably a more forgiving implementation would not prune out the prohibited style attributes but would honour them anyway, thus making it more broadly applicable to TTML in general. However I don't understand why the behaviour you're seeing is occurring - the default/initial values for extent and origin would apply in the absence of other style attributes, and text should not fall off the bottom in that case. There's possibly something else at play too. |
Thanks for fixing the issue, David. Thanks for quick resolution of the issue. Ryan Chan |
Great, thanks for the confirmation. Assuming no one else howls, @AkamaiDASH will need to do the merge. I imagine it will happen once 2.1.1 has been released which will probably be in the next couple of days. |
Got it. Thanks a lot :) |
Fixes #1340 - make TTMLParser more permissive of non-EBU-TT-D
Issue observed:
In 1.5.1 player, 2 out of 4 lines are rendered in the player. (as attached as 1_5_1_2_lines_only)
In 2.1.0 player, 1 and a half lines out of 4 lines are rendered in the player. (as attached as 2_1_0_1_and_a_half_line_only)
Expected behavior:
All 4 lines are fully rendered and displayed in the player.
Player that can reproduce the issue:
http://dashif.org/reference/players/javascript/v1.5.1/samples/dash-if-reference-player/
http://dashif.org/reference/players/javascript/v2.1.0/samples/dash-if-reference-player/
Content that can reproduce the issue:
(as attached as 4lines.zip)
Thanks!
![1_5_1_2_lines_only](https://cloud.githubusercontent.com/assets/5735739/14628154/f3e424e2-062d-11e6-8145-f9fa18d02129.png)
![2_1_0_1_and_a_half_line_only](https://cloud.githubusercontent.com/assets/5735739/14628155/f3e9cbcc-062d-11e6-8810-b1ad2f01e8df.png)
Ryan Chan
4lines.zip
The text was updated successfully, but these errors were encountered: