-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MPD Anchors #1361
Comments
Note that the examples in Appendix C are incorrect and were fixed in Corrigendum 1. |
#1390 handles #t, which is the one we're interested in our use case. Does anyone have a desire to use the others? If not I think they may be best left on the backlog until someone wants them. |
As discussed at the F2F, #1390 only supports value specified in seconds for |
Media Fragments URI 1.0 is a set of broad requirements, including spatial descriptors, many of which are edge case requirements. In support of @LloydW93's proposal, I would think we can cherry pick a subset of this to support at first for dash.js, specifically: t=10,20 # => results in the time interval [10,20) Additionally, I think supporting the utc parameter as defined by Amd.3 of ISO/IEC 23009-1:2014 would be most useful in practice: Start a live stream at Wed, 21 Jan 2015 20:04:05 GMT We can add support for other features of MediaFragments and Amd 3:2014 if and when people come forth and say they need them. |
The case of stopping at specific times isn't yet implemented. This should be relatively simple:
However, what UX should be exposed in this case, at least in the reference player? Is the entire available period exposed in the seek bar (and in the DVR Info by dash.js for live streams), or only the requested range? I'm thinking dash.js should always expose the entirely available range and leave that decision to the client, but that then means we need to ensure that seeking out of the initially provided range is handled. |
the changes are currently not part of development branch. is this intented? |
We currently only support #t= and #s=, and then only without ranges. We do generally have a desire to implement these further though, as it will be incredibly useful for MPD chaining. |
@LloydW93 I only see support of #s in development branch in PlaybackController.js in getStreamStartTime |
So looks like it was reverted by dave and I do not see the changes in the PR in dev either so must of not been included after the revert. @LloydW93 I faintly remember a discussion around this but do not have a clear idea if we made a mistake and did not re-add the code lines. |
as @LloydW93 already mentioned: at least the support of #t should be implemented, which should be a 1 liner. |
Fix regression resulting in #t no longer working (see issue #1361)
FYI I'm interested in #period support ! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it. Thank you for your contributions. |
Dash.js already has support for "#s=n", where n is a start offset in seconds. However, ISO23009-1 Appendix C specifies four MPD anchors:
t
parameter is not present, its default value is 0.Period@id
. If period parameter is not present, the default value is the ID of thePeriod
with the earliest PeriodStart.AdaptationSet@id
AdaptationSet@group
Dash.js should add support for at least #t, as this is something that current works if you pass an media url to a native media tag in a browser (https://www.w3.org/TR/media-frags/).
The text was updated successfully, but these errors were encountered: