Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Virtual Buffer #1365

Closed
dsparacio opened this issue Apr 27, 2016 · 3 comments
Closed

Refactor Virtual Buffer #1365

dsparacio opened this issue Apr 27, 2016 · 3 comments
Assignees
@dsparacio
Labels
Code Refactor Feature Enhancement Pri-High
Milestone
v2.3.0

Comments

@dsparacio
Copy link
Contributor

It would be nice to clean up and simplify VB
Make it useful for quality switch mapping and pruning.
We need to know what has been appended at time and quality for all chunks. This way we can prune for ABR needs.
@dsparacio dsparacio added this to the 2.2.0 milestone Apr 27, 2016
@dsparacio dsparacio self-assigned this Apr 27, 2016
@davemevans davemevans mentioned this issue Apr 28, 2016
Closed
@dsparacio
Copy link
Contributor Author

Turns out VB is not needed at ALL for Fast switch ABR or quality change events FragmentModel Executed Request Data is perfect for this. Nonetheless I have refactored the VB a bit as part of the fast switch changes. We can discuss this at Face to Face and determine how to proceed. At this point I only store Media Segments for lookup in NextRequestRule. Init segs gett appended to VB and then stored still. Goal is to refactor to not store any Media Chunks just media info with time range to reduce object size in memory. No need to store mdat box etc.

@dsparacio dsparacio removed their assignment Jun 3, 2016
@dsparacio dsparacio modified the milestones: v2.3.0, 2.2.0 Jul 5, 2016
@dsparacio
Copy link
Contributor Author

Need to work on this issue along with this refactor - #1482

@dsparacio dsparacio mentioned this issue Jul 11, 2016
Closed
5 tasks
@dsparacio dsparacio self-assigned this Jul 11, 2016
@dsparacio dsparacio mentioned this issue Aug 2, 2016
Merged
@dsparacio
Copy link
Contributor Author

Fixed with pr #1523

spiterikevin added a commit to spiterikevin/dash.js that referenced this issue Aug 2, 2016
@spiterikevin
Merge pull request #10 from AkamaiDASH/Dash-Industry-Forum#1365
833ffec 
Dash-Industry-Forum#1365
spiterikevin added a commit to spiterikevin/dash.js that referenced this issue Aug 5, 2016
@spiterikevin
Merge pull request #11 from AkamaiDASH/Dash-Industry-Forum#1365
fff7388 
Made priority more clear with const, explicit insert and removed sort…
spiterikevin added a commit to spiterikevin/dash.js that referenced this issue Aug 5, 2016
@spiterikevin
Merge pull request #12 from AkamaiDASH/Dash-Industry-Forum#1365
94cc15e 
Fixed race condition found by refactor revealing long issue in schedu…
dsparacio pushed a commit that referenced this issue Aug 5, 2016
Merge pull request #1523 from AkamaiDASH/#1365
9150dd2 
Major Refactor reduces complication, increases dependability and solve critical bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsparacio dsparacio

Labels
Code Refactor Feature Enhancement Pri-High
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
1 participant
@dsparacio