Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment request URLs incorrect when using a SegmentList #1379

Closed
padninja opened this issue May 5, 2016 · 5 comments
Closed

Fragment request URLs incorrect when using a SegmentList #1379

padninja opened this issue May 5, 2016 · 5 comments

Comments

@padninja
Copy link

padninja commented May 5, 2016

========= Issue submission guidelines (you may delete the text below after reading it ) =========
Before creating a new issue around a potential bug please:

  1. Check your browser's console for 404s (MPD file or media fragments)
  2. Check for Access-Denied errors which indicates an issue with the server's HTTP access control (CORS)
  3. Please use the Dash Validator (http://dashif.org/conformance.html) to make sure your MPD and media fragments conform before you file an issue.
  4. View the Javascript console to see the debug traces produced by the reference player. They may indicate why your content is not playing.
  5. When you do file an issue please add as much info as possible:
  • Your dash.js, browser and OS system versions
  • Valid MPD test content - ideally the URL to the manifest or a static copy of it if it is not public.
  • The relevant excerpt from the console trace showing the problem.
  • A clear sequence of steps to reproduce the problem.
@padninja padninja changed the title Relative BaseURL at Representation level does not work Fragment request URLs incorrect when using a SegmentList May 5, 2016
@padninja
Copy link
Author

padninja commented May 5, 2016

When using a relative BaseURL at the Representation level and a SegmentList, the fragment request URLs use duplicate relative baseURL values.

If the BaseURL tag contained "eagle-eye_dashinit.mp4" then the fragment request URL would look like:

http://10.1.15.51:8080/dash/eagle-eye_dashinit.mp4eagle-eye_dashinit.mp4

Here is the MPD we are testing with:

`

<Title>/tmp/dash/eagle-eye.mpd generated by GPAC</Title> eagle-eye_dashinit.mp4 ...`

@davemevans
Copy link
Contributor

The MPD has been mangled. Can you either host your MPD publicly, attach it as a text file or use multi-line quotes ``` above ?

@padninja
Copy link
Author

padninja commented May 5, 2016

Sorry about that. MPD attached.
eagle-eye.txt

@davemevans
Copy link
Contributor

Yes, I can see what is happening here.

Since SegmentURL@media is not present, Representation@BaseURL is used, as the spec requires. However, the BaseURL is now resolved seperately and therefore Representation@BaseURL is appended twice.

Can you try changing ListSegmentsGetter.js:L70 to seg.media = s.media ? s.media : ''; and check it fixes the issue? (Note you may need to comment out L45,46 to get it to build).

@padninja
Copy link
Author

padninja commented May 5, 2016

Yes, that works. Thank you.

@davemevans davemevans added this to the 2.2.0 milestone May 9, 2016
LloydW93 pushed a commit that referenced this issue May 9, 2016
Fixes #1379 - map BaseURL to SegmentURL correctly when media is not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants