Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML Parser incorrectly scales root container region by cellResolution #1432

Closed
5 tasks done
davemevans opened this issue Jun 1, 2016 · 3 comments
Closed
5 tasks done
Labels
Milestone

Comments

@davemevans
Copy link
Contributor

davemevans commented Jun 1, 2016

Environment
Steps to reproduce

Play MPD linked above. Occurs 100% of the time.

Observed behaviour

Root Container Region is being vertically scaled by some ratio of the cellResolution. This can be observed by inspecting the elements in the developer tools. I don't think this is correct. EBU 3380 states 'If the related media object is a video media object then the rendering plane shall be coincident with the rendering plane of the video media object' which I assume to mean it is the same size. The cell resolution is used for calculating line padding, font size etc, but the container should not be scaled by it.

I tried simply removing the "aspect ratio" passed to getVideoVisibleVideoSize from checkVideoSize but this appears to cause other scaling issues.

Console output

N/A

@davemevans
Copy link
Contributor Author

davemevans commented Jun 1, 2016

To make this work with the MPD supplied, you need to pull in #1427.

However, this effect is noticeable without that patch. See http://rdmedia.bbc.co.uk/dash/ondemand/elephants_dream/1/client_manifest-all.mpd, which gives the same result without requiring #1427.

#1427 has now been pulled into dev.

@nigelmegitt
Copy link
Contributor

Just in case it's relevant, the ttp:cellResolution parameter in a TTML document carries no information about the aspect ratio: it's merely used to divide the root container region into a cell grid that can be used as a coordinate system. The individual cells are not constrained to be square or any other aspect ratio: their aspect ratio depends on the root container region aspect ratio and the number of cells in each dimension.

@TobbeEdgeware
Copy link

@bbcrddave This is probably incorrect, but has been like this for a very long time. I've never worked with the actual HTML rendering and scaling, so if you know how to fix it, please do so.

dsparacio pushed a commit that referenced this issue Jun 13, 2016
Fix #1432 - cellResolution does not convey aspect ratio
@dsparacio dsparacio added this to the 2.2.0 milestone Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants