Uncaught TypeError when quality is -1

[davemevans]

Environment

• The MPD passes the DASH-IF Conformance Tool on http://dashif.org/conformance.html
• The stream has correct Access-Control-Allow-Origin headers (CORS)
• There are no network errors such as 404s in the browser console when trying to play the stream
• The issue observed is not mentioned on https://github.com/Dash-Industry-Forum/dash.js/wiki/FAQ
• The issue occurrs in the latest reference client on http://dashif.org/reference/players/javascript/ and not just on my page
• Link to playable MPD file: http://dash.edgesuite.net/dash264/TestCases/1a/sony/SNE_DASH_SD_CASE1A_REVISED.mpd
• Dash.js version: dev
• Browser name/version: Chrome 51
• OS name/version: Win 7

Steps to reproduce

1. Load MPD with console open

Observed behaviour

Uncaught TypeError: Cannot read property 'MSETimeOffset' of null

In createBuffer, streamProcessor.getRepresentationInfoForQuality(requiredQuality) will return undefined if requiredQuality is -1 which it could be if no quality update event has been triggered. When .MSETimeOffset is accessed, a TypeError is thrown.

This has been alluded to on the mailing list and in PR #1436. Probably caused by #1434.

[davemevans]

I get a different uncaught TypeError with streams with fragmented text (eg http://rdmedia.bbc.co.uk/dash/ondemand/elephants_dream/1/client_manifest-all.mpd), which seems to be caused by a quality of -1.

Console log is RepresentationController.js:284 Uncaught TypeError: Cannot read property 'adaptation' of undefined. getCurrentRepresentation is returning undefined for fragmentedText.

[dsparacio]

My bad, this should be a quick fix.

[dsparacio]

Fixed with PR #1443