Single QUALITY_CHANGE_COMPLETE event triggered when multiple expected

[davemevans]

If you switch quality, allow at least one segment at the new quality to be buffered, then switch quality again before the first change has been rendered, you only get one QUALITY_CHANGE_COMPLETE event.

I would expect a QUALITY_CHANGE_COMPLETE event to be triggered for each quality change request but ScheduleController.onBytesAppended only allows one rendering check to be active at any one time.

[dsparacio]

We had a long discussion about this. Adding feature enhancement. It is acting as designed at this point.

Nonetheless we have to store a render point for each quality and do more logic to allow "overlapping quality switch windowing events" to work in parallel. Mouth full.

The solution is to add a dict with quality index and render point for each rep. Clearing render point once reached by playhead time. Need to add a payload value of to QUALITY_CHANGE_COMPLETE noting what index this is complete for.

They player then can decide what events to act upon or ignore.

[davemevans]

#1510 does appear to fix this, although I am still not clear how to handle the unresolved quality change request in my use case. That is not your problem though 😛