We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msExtendedCode should not be called on a non existing error object
function onPlaybackError(e) { var code = e.error ? e.error.code : 0; var msg = ''; if (code === -1) { // not an error! return; } switch (code) { case 1: msg = 'MEDIA_ERR_ABORTED'; break; case 2: msg = 'MEDIA_ERR_NETWORK'; break; case 3: msg = 'MEDIA_ERR_DECODE'; break; case 4: msg = 'MEDIA_ERR_SRC_NOT_SUPPORTED'; break; case 5: msg = 'MEDIA_ERR_ENCRYPTED'; break; default: msg = 'UNKNOWN'; break; } hasMediaError = true;
if (e.error.msExtendedCode) { msg += ' (0x' + (e.error.msExtendedCode >>> 0).toString(16).toUpperCase() + ')'; } log('Video Element Error: ' + msg); if (e.error) { log(e.error); } errHandler.mediaSourceError(msg); reset(); }
The text was updated successfully, but these errors were encountered:
I thought I fixed this a while back, but looks like it got lost somewhere... I'll pick this up now.
Sorry, something went wrong.
Fixes Dash-Industry-Forum#1494
17cf0ff
5e772ea
45f2893
Merge pull request #1495 from bbc/fix-1494
1c9ef51
Fixes #1494
04fef14
No branches or pull requests
Steps to reproduce
Observed behaviour
msExtendedCode should not be called on a non existing error object
Good management of a null error object at the beginning of the function
Missing management of a null error object here
The text was updated successfully, but these errors were encountered: