Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduleController still listens to PLAYBACK_TIME_UPDATED after reset, throws TypeError #1518

Closed
davemevans opened this issue Jul 28, 2016 · 0 comments
Milestone

Comments

@davemevans
Copy link
Contributor

#1510 introduced a PLAYBACK_TIME_UPDATED event listener to handle quality change events, but this is not removed when ScheduleController is reset.

Subsequent events cause the callback to be called, but ScheduleController's state has been reset and a TypeError is thrown when attempting to access playbackController methods since this object is now null.

Steps to recreate: in ref player select any sample stream and wait for it to start, then click load again.

I'll issue a PR shortly.

@davemevans davemevans mentioned this issue Jul 28, 2016
LloydW93 pushed a commit that referenced this issue Jul 28, 2016
@davemevans davemevans added this to the v2.3.0 milestone Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant