Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-representation video-only OR audio-only streams throw TypeError #1588

Closed
davemevans opened this issue Sep 12, 2016 · 1 comment
Closed

Multi-representation video-only OR audio-only streams throw TypeError #1588

davemevans opened this issue Sep 12, 2016 · 1 comment
Assignees
@davemevans @dsparacio
Labels
Bug
Milestone
v2.4.0

Comments

@davemevans
Copy link
Contributor

#1580 and #1586 were both fixed by #1581 but the fix provided only works for streams with a single representation.

http://rdmedia.bbc.co.uk/dash/ondemand/bbb/2/client_manifest-audio.mpd, for example, is audio-only, with multiple audio representations. Attempting to play this throws Uncaught TypeError: Cannot read property 'length' of null. This is because createMenu is called (because audio.length is > 1) and still assumes that info.video exists.

I think the answer is to ensure that these attributes always exist but with length 0.
davemevans added a commit to davemevans/dash.js that referenced this issue Sep 12, 2016
@davemevans
Fixes Dash-Industry-Forum#1587, Dash-Industry-Forum#1588
579a480
@dsparacio dsparacio added the Bug label Sep 12, 2016
@dsparacio dsparacio added this to the v2.4.0 milestone Sep 12, 2016
dsparacio pushed a commit that referenced this issue Sep 12, 2016
Merge pull request #1589 from bbcrddave/ControlBarFixes
be43508 
Fixes #1587, #1588
@davemevans
Copy link
Contributor Author

Fixed by #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davemevans davemevans

@dsparacio dsparacio

Labels
Bug
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
2 participants
@davemevans @dsparacio