Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError in StreamController occurs when video loops #1638

Closed
5 tasks done
sureshmurali opened this issue Oct 24, 2016 · 3 comments
Closed
5 tasks done

Uncaught TypeError in StreamController occurs when video loops #1638

sureshmurali opened this issue Oct 24, 2016 · 3 comments
Labels
Milestone

Comments

@sureshmurali
Copy link

sureshmurali commented Oct 24, 2016

Environment
Steps to reproduce
  1. Load and play VOD mpd file (LOOP ENABLED)
  2. Seek to near end of video
  3. Video ends and playback initializes
  4. Uncaught TypeError occurs in StreamController
Observed behaviour

No problem in video playback.

Console output
StreamController.js:310 Uncaught TypeError: Cannot read property 'getStreamInfo' of null

image

image

@sureshmurali sureshmurali changed the title Uncaught TypeError in StreamController occurs when ends and loops Uncaught TypeError in StreamController occurs when video loops Oct 24, 2016
@dsparacio
Copy link
Contributor

Already working on a fix for this for Multiperiod. I should be in this PR once I commit the latest
#1631

@dsparacio
Copy link
Contributor

Resolved in #1631

@davemevans
Copy link
Contributor

This is still an issue.

Appears to be because the PLAYBACK_ENDED callback in main.js is registered (and therefore called) before the StreamController callback (onEnded). main.js ultimately calls StreamController.reset which destroys the state later required by onEnded.

I suppose all of StreamController.getNextStream could be wrapped in an if (activeStream) or something.

@davemevans davemevans reopened this Dec 7, 2016
@davemevans davemevans added the Bug label Dec 7, 2016
@davemevans davemevans added this to the v2.4.0 milestone Dec 7, 2016
dsparacio pushed a commit that referenced this issue Dec 7, 2016
Fix #1638 - ensure activeStream is not undefined in onEnded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants