Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot type URL in Reference Player. Looses focus after angular update #1653

Closed
TobbeEdgeware opened this issue Nov 2, 2016 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@TobbeEdgeware
Copy link

Environment
  • Dash.js version: Commit d4a6152
  • Browser name/version: Chrome 54.0
  • OS name/version: OS X 10.11.6
Steps to reproduce

Open locally built dash-if-reference-player in Chrome

Observed behavior

The URL window looses focus after each character being typed.
This did not happen with dash-if-reference-player built from 1b037ce.

The commit updates Angular from 1.0.7 to 1.5.8.
I tried replacing 1.5.8 with 1.2.20 (last legacy version) and the problem disappeared.

I don't see the same problem in Safari 10.0.1 and Firefox 49.0.2

@dsparacio
Copy link
Contributor

OK good catch. I always paste in not type. I will check this out right away and see what the issue is.

@dsparacio dsparacio added this to the v2.4.0 milestone Nov 2, 2016
@dsparacio dsparacio self-assigned this Nov 2, 2016
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Nov 2, 2016
@dsparacio
Copy link
Contributor

Fixed with PR #1655

dsparacio pushed a commit that referenced this issue Nov 2, 2016
@TobbeEdgeware
Copy link
Author

@AkamaiDASH Thanks for the quick fix, Dan!

@dsparacio
Copy link
Contributor

No problem thanks for reporting it. Was interesting learned more about angular. We are doing some major stuff "wrong" in that player. Opportunity to learn more about angular I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants