Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mistake in conversion to big endian in MssFragmentProcessor #1850

Closed
Andgoncharov opened this issue Mar 31, 2017 · 2 comments
Closed

A mistake in conversion to big endian in MssFragmentProcessor #1850

Andgoncharov opened this issue Mar 31, 2017 · 2 comments

Comments

@Andgoncharov
Copy link

In the 501 and 505 lines of MssFragmentProcessor.js 0x0000F000 mask is used instead of 0x0000FF00, when converting to big endian.

 avcC[i++] = (avcCLength & 0xFF000000) >> 24;
    avcC[i++] = (avcCLength & 0x00FF0000) >> 16;
    **avcC[i++] = (avcCLength & 0x0000F000) >> 8;**
    avcC[i++] = (avcCLength & 0x000000FF);

    esds[i++] = (esdsLength & 0xFF000000) >> 24; // esds box length
    esds[i++] = (esdsLength & 0x00FF0000) >> 16; // ''
    **esds[i++] = (esdsLength & 0x0000F000) >> 8; // ''**
    esds[i++] = (esdsLength & 0x000000FF); // ''
@nicosang
Copy link
Contributor

Thanks again @Andgoncharov.

dsparacio pushed a commit that referenced this issue Apr 4, 2017
@LloydW93
Copy link
Member

Closing as looks fixed in 1851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants