Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTCTiming (http-head) is treated as relative to page (instead of MPD) #2333

Closed
5 tasks done
sandersaares opened this issue Dec 11, 2017 · 3 comments
Closed
5 tasks done

Comments

@sandersaares
Copy link
Member

Environment
Steps to reproduce
  1. Start playback.
  2. Observe network traffic.
  3. Compare against Shaka player to verify deviation.
Observed behaviour

dash.js sample player fails to resolve time according to the UTCTiming element and instead uses Akamai server for time sync.

The apparent cause is that the UTCTiming element specifies a relative URL. dash.js appears to treat it as relative to the website the player is hosted in. Relative to the page, this is a 404, so presumably dash.js falls back to Akamai.

I would expect it to instead treat the UTCTiming URL as relative to the MPD (or its BaseURL, if any, which in this case is none).

It is true that DASH does not actually specify anything about relative URLs here but Shaka player treats it this way and it seems to make logical sense, so seems like the most interoperable behavior.

@davemevans
Copy link
Contributor

Fix at davemevans@5d37900 - please test and I will provide a PR.

@epiclabsDASH
Copy link
Contributor

@sandersaares, did you have the time for testing @bbcrddave proposed changed?

@sandersaares
Copy link
Member Author

sandersaares commented Dec 15, 2017

I confirm the linked change fixes the issue.

It still does not bring dash.js into sync with Shaka, interestingly enough, but I think that is a separate issue. https://shaka-player-demo.appspot.com/demo/#asset=https://live.axtest.net/Channels/Test1/Manifest.mpd;lang=en-US seems to be around 5-20 seconds ahead of dash.js. Assuming it is not a difference so big that they are playing entirely different periods (I will also try to create a stream with longer periods to verify).

epiclabsDASH added a commit that referenced this issue Dec 15, 2017
Fix #2333 - ensure UTCTiming is resolved relative to MPD base uri or BaseURLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants