Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2527 exposes other issue causing constant rerequesting of valid TTML segments #2547

Closed
davemevans opened this issue Apr 24, 2018 · 0 comments

Comments

@davemevans
Copy link
Contributor

It is totally valid to have a segment containing a valid TTML document which contains nothing to display and this is required in order not to have gaps in the timeline.

Unfortunately, #2527 in conjunction with an existing dubious piece of code (https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/utils/TTMLParser.js#L156) causes the player to continually re-request and discard perfectly valid TTML.

The TTML parser and text source buffer need to be more intelligent - it should be possible to determine the difference between valid empty documents and those which are erroneous and handle the situation accordingly.

I'll submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant