Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EssentialProperties on AdaptationSets not working #4125

Closed
stschr opened this issue Feb 10, 2023 · 2 comments
Closed

EssentialProperties on AdaptationSets not working #4125

stschr opened this issue Feb 10, 2023 · 2 comments
Milestone

Comments

@stschr
Copy link
Contributor

stschr commented Feb 10, 2023

Considering the simpliest case, where an AdaptationSet containing one Representation, it sould be irrelevant if an EssentialPropertydescriptor is present on Representation or AdaptationSet level.

With latest released version of dash.js, when setting an EssentialProperty descriptor with a unknown @schemeIdUri on a Representation, this representation gets removed as expected.
However, moving the same descriptor to the parent AdaptationSets will keep this AdaptationSet in the list of available tracks.

  • Is objectiron expected to "move" the essentialproperty to the containing Representation?
    OR
  • Shall the essentialProperty filtering be applied on AdaptationSets as well?

I can provide a simple demo application if desired
related: #3510

@dsilhavy
Copy link
Collaborator

To be honest I was assuming that we already move everything via objectiron. DashConstants.SUPPLEMENTAL_PROPERTY and DashConstants.ESSENTIAL_PROPERTY are part of RepresentationBaseValuesMap. But as you pointed out the values are not moved. It would be cleaner to fix this.

@dsilhavy
Copy link
Collaborator

Addressed in #4172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants