Fixing essentialProperties in ObjectIron #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: #4125
This is just a quick hack to get ObjectIron to process
EssentialProperty_asArrayin addition toEssentialProperty.This is required since
DashManifestModel.js/getEssentialPropertiesForRepresentation() only processesEssentialProperty_asArray, but notEssentialProperty`.I have not checked whether any other entry in
commonPropertiessuffers from the same issue.@dsilhavy : Please comment on how to proceed with this issue - IMHO it would be good to get this fixed for V4.7.0.
(Note: I've not seen any unit test on ObjectIron at all.)