Wrong index returned for AbrController.getQualityForBitrate

[davidgarry]

HI everybody,

I have the following bitrates list :

• 0 : 400 000
• 1 : 700 000
• 2 : 1 000 000
• 3 : 1 300 000
• 4 : 1 800 000
• 5 : 2 500 000

When I call the method MediaPlayer.setQualityFor('video', 5), the process call the method getQualityForBitrate(mediaInfo, 2500), and it returns 4 instead of 5, due to the line : return Math.max(i-1, 0);

In the block code below :

for (var i = 0; i < ln; i +=1) {
                bitrateInfo = bitrateList[i];

                if (bitrate*1000 <= bitrateInfo.bitrate) {
                    return Math.max(i-1, 0);
                }
}

So, I can't set the quality to 2500. Is there a reason to send the previous index when bitrates are equals ?

Regards,

[KozhinM]

@AkamaiDASH, looks like this code is a part of your implementation of fragment abandonment:
21a3026
I believe I remember hearing an explanation from you about this particular modification, but I do not remember the details and the reasons. I hope you do :)

[dsparacio]

lol... it's foggy @KozhinM . I think it was to handle something on the opposite end when the bitrate sent in is lower the the lowest listed bitrate but I can not remember. I look for some email and test it. let me get to a place where i can test but looking at it and from the description @davidgarry it seems wrong and a bug. I'll follow up in a bit.

[davidgarry]

@AkamaiDASH, do you have some news about this issue ?

[dsparacio]

Seems like a valid bug but no have not looked yet and most likely will not for a bit. We are in the middle of a huge refactor so I am not in my normal state to look closely. Maybe just fix the one line you pointed out the notes in your code branch and we will fix in the next release. It would be very helpful if you could add a detailed issue to the issue tracker as well.

[JibberJim]

This is certainly a bug, simple fix committed on our branch as above, don't see the point creating a pull request while the refactor is ongoing, but let me know.

[dsparacio]

This change did not make it up to 2.0 so I need to add bbc@6639326
to 2.1

[dsparacio]

Fixed and directly pushed into dev without a PR.