-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btoa and atob declarations break native browser implementations for other libraries #866
Comments
@thomaspeeters +1 And I find it will break Chrome if you force to play video in Flash mode. IMHO, this implementation may trying to make Perhaps removing the |
Thanks for the reply. |
I think we are going to put this in a temp 1.5.2 patch release until we can get the 2.0 version out. We will need to merge these changes in one by one manually into 2.0 so trying to overload this small release. |
Sounds good to me. On a slightly unrelated note, do you have an ETA for 2.0? |
Not on 2.0 just yet most likely mid Jan 2016. But the 1.5.2 should be out next week sometime. |
Alright, thanks for the update. From the note in 2b78bd5, I was under the impression 2.0 would have been ready on the development branch by the end of November. |
We will have something in Dev most likely right after the Dec 9th Face to face meeting. At this point we can all work on bug fixes / enhancements in the refactored branch. This will involve moving all the 1.5.2 changes that are applicable. |
Gotcha, thanks for the info. |
Another issue that was not pulled in from 1.6.0 to 2.0. It will be added to dev right away and released with 2.1 |
Please implement changes from MobiTV-AB@73486d3 in dev |
missed code was added back in and push directly to dev without a PR. |
I'm currently trying to set up a video.js player using dash.js, videojs-contrib-dash and videojs-contrib-hls.
videojs-contrib-hls uses
window.btoa
several times and it seems this part of dash.debug.js overrides this native implementation ofbtoa
.This isn't a problem in Firefox and Chrome, but breaks playback of HLS streams in IE (tested in IE11 on Win7).
I did some testing and following changes fix the problem:
var
keywordencodeASCII
anddecodeASCII
as per atob/btoa got patched on chrome #419btoa
andatob
seem to have been removed.The text was updated successfully, but these errors were encountered: