[2.0] Some API methods don't work before play

[LloydW93]

createControllers is not called until play() is first ran. This could potentially be problematic if you want to use a call such as setInitialBitrateFor.

For example, we do something like:

var dashPlayer = MediaPlayer().create();
dashPlayer.initialize();
// various settings such as setScheduleWhilePaused, setAutoSwitchQuality
dashPlayer.attachView(video);
dashPlayer.attachSource(connection);

I'm currently working around this for testing and playing with by adding createControllers() to the initialize function, but am not sure if that's the best place for it.

[wilaw]

I noticed the same thing when trying to use setLiveDelayFragmentCount() - could only be called after initialize() had been called. The issue as you point out is that createControllers() is only called inside play(). This seems rather late in the stack and the controllers being created don;t really have any dependencies besides context.

How about adding createControllers() to setup() function? This is the first function called upon instantiation of a new MediaPlayer. I tested this and it worked well with my setLiveDelayFragmentCount() use case. Other samples seem to work too as well as build-up and tear-down of the instance. Does this also work for your setInitialBitrateFor case?

-Will
PS. Dan is out on vacation rest of this week reducing the Hawaiian MaiTai supply, so he won't be able to comment until next Monday.

[LloydW93]

Yep - putting it in setup works too - I just wasn't sure if there was an active decision not to put it there. We can check with Dan when he's back?

[LloydW93]

setup doesn't work in the case where a stream finishes and you attempt to play another - some controllers are immediately torn down.

[dsparacio]

@LloydW93 @wilaw I'll take a look soon. Never liked the create call in play was there for your last comment problem. Many todos around dash handler/parser create stuff. Ill take a look to come up with a better object creation process.

Dan

[dsparacio]

Solution will be to use the mediaPlayerModel to store data before controllers are initialized. This was the intent of this object and is already in place. I will fix this. Thanks for catching this.

[dsparacio]

Fixed with PR #1041