Use device pixel ratio to calculate size of portal for max representation size

[nickygerritsen]

This uses window.devicePixelRatio (if set) to calculate the element width and height.

This makes sure that devices that have a device-pixel-ratio of more than 1 (e.g. Retina iOS / Mac devices) will get the correct quality video. See also #1028 where I suggested doing this.

[nickygerritsen]

Any opinions on this?

[dsparacio]

@nickygerritsen Sorry it is not that I missed this PR I was seeing if @LloydW93 who implemented the ratio limit stuff had any comments. It may be too late unless there is great argument to push this into 2.0 so it may need to move to 2.1. Is that I big setback for you?

[LloydW93]

Sorry - Unlike Dan I did forget about this.

I think at our end we think this is obviously a useful feature to have, but that a feature toggle would be useful. We'd need to have lots of conversations internally before we would actually be able to turn it on in our use case, but this should not be a reason to hold it back generally.

[dsparacio]

Thanks @LloydW93 . I agree a way to disable this with API at media player is crucial. Now the question is 2.0 or 2.1.

[nickygerritsen]

I could try to modify it to have an option, similar to the option to use viewport size?

[dsparacio]

If you mod it to have option and rebase it could be put in. t is only tuesday morning here in US but I worry about other timezones and testing and voting to try to make a Friday deadline. I am ok if others are. Looks like we may need a new RC today anyway so if you can do this soon, why not? It has been in the queue well before the deadline for PR.....

[nickygerritsen]

Hmmm it is evening here in CET, so I can not do it within the next 12 hours....

[dsparacio]

Ah was not aware you are in CET sorry my bad. not sure if we can keep pushing non critical stuff at this point. This CR has had conflicts for a bit and we should of visited this at RC1 or PR deadline last week. My bad for not admining this correctly but my gut feeling is it should wait until 2.1 and be first in.

[nickygerritsen]

No problem. What is the ETA on 2.1? I can still try to add the options, but then it is maybe better to re-start from the current master?

[dsparacio]

NO official timeline yet but we want it out by NAB in mid- April and we want to starting doing faster releaser cycles around 6 weeks. This all lines up nicely.

[nickygerritsen]

OK then I know that I don't have to rush too much for now for this to be in 2.1 :). i.e. no tomorrow-first-thing-thingy

[dsparacio]

Closing covered with PR #1429