Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #1573 . It adds a
StringMatcher
to the DASH parser.The issue identified the specific case of
Period@id
attributes, however there are many other attributes in the DASH MPD that, according to the schema, are also typexs:string
.StringMatcher
therefore contains a mapping table listing every attribute I could find the the schema that is defined as being of typexs:string
.The
StringMatcher
needs to know the name of the node as well as the name of the attribute.xml2json.js
was therefore modified to provide this as an argument to the test method. Although attributes currently have anownerElement
property that would provide this information (without needing to modifyxml2json.js
) this will eventually be deprecated in DOM4+ according to https://developer.mozilla.org/en-US/docs/Web/API/Attr