Adds getLiveDelay to MediaPlayer API #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should allow integrations / player plugins for checking if other component
tchakabam
changed the title
dsparacio
reviewed
Sep 21, 2016
| * @returns {number} Current live stream delay in seconds | ||
| */ | ||
| function getLiveDelay() { | ||
| return mediaPlayerModel.getLiveDelay(); |
There was a problem hiding this comment.
Good API to have as we are still missing live delay subtraction from DVR Metric. Meaning that control bar will render duration without live delay factored. I am fixing this now but this is useful. Thanks.
dsparacio
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow integrations / player plugins for checking if other components set this concurrently