Bugfix for rendering CEA608 captions embedded in H264 SEI #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If composition_time_offset flag is not set in trun box header, it is leading to garbled CC text rendering. * This is caused by "undefined" sample.sample_composition_text_offset field. * codem-isoboxer expects the caller to resolve to the defaults.
|
Looks good to me. |
davemevans
approved these changes
Oct 17, 2016
There was a problem hiding this comment.
NOTE: default_sample_duration and default_sample_size could return undefined since they are not mandatory in the tfhd box (admittedly this would represent a broken stream). But there's not a lot that could be done in that case other than fail gracefully.
Still, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leading to garbled CC text rendering.
field.