Fail properly when Base URL Resolution fails #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging #1701 showed a bug that has always existed but was only exposed once the fast switch changes were added.
If URL resolution fails, an event is fired which stops the scheduler. If you subsequently try to resolve a Base URL after this (which in theory should never happen, but can in certain circumstances), the resolver can return unexpected results. This change ensures that no sensible result is returned once a failure has occurred.
This is a one line change (L91, BaseURLController) - all the other stuff is simply to get the test running to verify the fix.