Fix #1731 - ensure BaseURLs are resolved properly for SegmentBase #1732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest in #1731 showed up an issue where
BaseURLs
were not resolved properly forSegmentBase
elements if they had a path in them because the path element appeared to be resolved twice. The reason for this was thatSegmentBase
andBaseURL
manifest types were copying theBaseURL
element toinitialization
, but still resolving the BaseURLs anyway, leading to the behaviour seen.Further, once the BaseURL resolution had been performed at startup time for these manifest types it could not be redone so they would not be able to benefit from BaseURL redundancy (although this is probably less of an issue since they are for on-demand use).
I tested these specific changes using:
... as well as the usual suspects from the sample list.
Also tested Webm with:
and these work great but we do not have enough test material for webm IMO.