fix for segmenttimeline live start #1729 #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when I refactored for Dynamic multiperiod I noticed a "way too complex" system used for liveedge search as a rule. I removed a ton of code to simplify this and that was successful except I missed one line that was critical for segmentTimeline since it does not use Timesync.
timelineConverter.setTimeSyncCompleted(true);
So for SegmentTimeline the seekAtStart was not called properly.
I believe setting this from a single point, at live edge search complete handler in schedule controller is the best place in the code. Other option is, we can add back in the handler into timelineConverter just to set this locally but I think that actually makes it more confusing . IMHO.
I tested with some URLS in the issues as well as all of the live streams in the live section in the player.
All is working as expected.