Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1759 (regression) resume correctly after seek #1761

Merged

Conversation

JontyUsborne
Copy link
Contributor

Fixes #1759 caused by 930717e.

Original reason for 930717e was a problem were segment lists were updated out of order such that the previously fetched index was sometimes no longer valid. For instance, if a paused player drifted outside of the rewind window, when seeking back, the getSegmentByIndex and getIndexForSegments functions would be using different segment lists.

Moving updateSegments fixed the issue, but caused problems for other streams where the segment list needs to be updated on every getSegmentRequestForTime call.

6650178 now works, but the whole thing could probably do with refactoring and the first updateSegments should probably go somewhere else.

@LloydW93 LloydW93 merged commit 219c0c6 into Dash-Industry-Forum:development Jan 25, 2017
@LloydW93 LloydW93 deleted the actualPresentationTime branch January 25, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Regression after recent PR merge) Failing to resume after seeking with some streams.
2 participants