feat(TextTrackInfo) Passthrough roles even if dash can't parse them #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming an AdaptionSet has roles defined, the only way to access them is via [`MediaPlayer#getTracksFor('text')`](http://cdn.dashjs.org/latest/jsdoc/module-MediaPlayer.html#getTracksFor__anchor). If the manifest is using fragmented text, then `MediaPlayer#getTracksFor('text')` will return `[]` and the only way to get the text track list is to listen for `TEXT_TRACKS_ADDED`. However, the `tracks` property in the `TEXT_TRACKS_ADDED` event is `TextTrackInfo[]`, which does not include the original `roles` from the manifest.
This will pass through whatever `roles` are found, allowing them to be accessed for all text track types.
|
Thanks good addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming an AdaptionSet has roles defined, the only way to access them is via
MediaPlayer#getTracksFor('text'). If the manifest is using fragmented text, thenMediaPlayer#getTracksFor('text')will return[]and the only way to get the text track list is to listen forTEXT_TRACKS_ADDED. However, thetracksin theTEXT_TRACKS_ADDEDevent isTextTrackInfo[], which does not include the originalroles.This will pass through whatever
rolesare parsed, allowing them to be accessed for all text track types.Possibly a workaround for #1236