Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setMinAllowedBitrateFor #1802

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Added setMinAllowedBitrateFor #1802

merged 2 commits into from
Mar 3, 2017

Conversation

forbesjo
Copy link

Closes #1799

forbesjo
forbesjo commented Feb 23, 2017
View reviewed changes
src/streaming/controllers/AbrController.js Outdated
}

var minBitrate = getMinAllowedBitrateFor(type);
if (!isNaN(minBitrate)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isNaN({}) is true so these blocks will never execute

@dsparacio dsparacio merged commit d19e523 into Dash-Industry-Forum:development Mar 3, 2017
@dsparacio
Copy link
Contributor

Thanks Guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@forbesjo @dsparacio