Adding typescript definitions for MediaPlayer #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbcrddave @nicosang Any thoughts? |
|
With my very limited knowledge of TS, this LGTM. Bear in mind that we will need to remember to keep this up to date as the MediaPlayer and other publicly-exposed API extends/changes over time. |
|
My knowledge on this point is even more limited....sorry. :-( |
|
@dunpeal are you willing to maintain this for each version released as the API is updated? None of us on the project use TypeScript |
|
@AkamaiDASH Yes, I will. I need some time to look around in project and include in work process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those who using dashjs in TypeScript project