Code refactoring #1822
Merged
Code refactoring #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicosang - Hey I am wondering are you able to review the code climate PR integration flags and are able to mark them and comment. Not sure what permissions other devs are seeing with this new tool. https://lima.codeclimate.com/github/Dash-Industry-Forum/dash.js/pull/1822 |
nicosang
force-pushed
the
CodeClimateIssues
branch
from
3700f56
to
a96f3de
Compare
|
@AkamaiDASH, the answer : "You are not authorized for this action". :-(. I wanted to set it as 'wontfix' and comment... |
|
@nicosang I figured as much. Let me figure this out and get back to the group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...from code climate issues