Create index handler in stream processor #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have always envisioned stream and stream processor becoming one object seems like a bit of duplication in those layers. |
nicosang
force-pushed
the
CreateIndexHandlerInStreamProcessor
branch
from
c2e2117
to
3a726c4
Compare
|
Indeed, I could do it in an other PR. |
nicosang
force-pushed
the
CreateIndexHandlerInStreamProcessor
branch
from
3a726c4
to
f1ea008
Compare
nicosang
force-pushed
the
CreateIndexHandlerInStreamProcessor
branch
from
f1ea008
to
da6ef09
Compare
nicosang
force-pushed
the
CreateIndexHandlerInStreamProcessor
branch
from
da6ef09
to
8b89621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexHandler is an attribute of StreamProcessor. This PR suggests to move createIndexHandler function in StreamProcessor. In the same way, SegmentBaseLoder is moved in DashHandler class.