Remove unnecessary references to manifest #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsparacio
reviewed
Apr 4, 2017
src/dash/models/DashManifestModel.js
Outdated
|
|
||
| for (var i = 0; i < ln; i++) { |
There was a problem hiding this comment.
If you are going to refactor this kind of stuff we would want to move to es6. This is a style that we decided on.
nicosang
force-pushed
the
CleanUpRequestNext
branch
from
7979b49
to
8d2c1ee
Compare
nicosang
force-pushed
the
CleanUpRequestNext
branch
from
b37db06
to
b04ba0d
Compare
nicosang
force-pushed
the
CleanUpRequestNext
branch
3 times, most recently
from
f814b5d
to
d3d285a
Compare
nicosang
force-pushed
the
CleanUpRequestNext
branch
from
d3d285a
to
6dda058
Compare
nicosang
force-pushed
the
CleanUpRequestNext
branch
3 times, most recently
from
4b2c80e
to
91c56d8
Compare
… on DashAdaptor singleton. Then, getStreamsInfo function doesn't need manifest as parameter : manifest has already been added like an attribute on each period.
…Controller doesn't need manifestModel as attribute
…ld has one for the MediaPlayer need.
update equality test between objects => use JSON.stringify function instead of === (test done on reference)
nicosang
force-pushed
the
CleanUpRequestNext
branch
from
91c56d8
to
f9aefc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea behind this Pull Request is to centralize the access to manifestModel object. When a manifest is downloaded, the callback 'onManifestUpdated' is called. I suggest to update Periods array in DashAdapter class. The manifest is added to each period object. So, we don't need, in each file, to set manifest as parameter. There is an exception : it's for getTracksForTypeFromManifest and getStreamsFromManifest functions of MediaPlayer. Those functions could be called for an unplayed stream.