Remove unused RulesController #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting I was not aware this happened. I looked in the commit 490cfea and saw this line in ABRController. Was this removed as well? |
|
Yes the line was removed and replaced by |
|
@jeremco odd CLAhub is saying not signed yet but not issue on your other PR. any clue. Would like to include this but some conflicts etc. Let me know if I can help you resolve stuff. |
jeremco
force-pushed
the
ABR_Unused_RulesController
branch
from
1d3857f
to
ec0ce7c
Compare
|
@AkamaiDASH The conflict is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules Controller is instantiated from MediaPlayer but never used by any of other controllers.
The logic has been moved in ABRController since commit 490cfea
The goal of this PR is to remove RulesController from repository