Controllers creation modifications #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremco
force-pushed
the
controllers_creation_modifications
branch
from
f07f680
to
9ddaebd
Compare
nicosang
force-pushed
the
controllers_creation_modifications
branch
from
421de0e
to
6c7e4d1
Compare
Closed
nicosang
force-pushed
the
controllers_creation_modifications
branch
from
0934758
to
f3fc83d
Compare
nicosang
force-pushed
the
controllers_creation_modifications
branch
from
015e175
to
9056a9f
Compare
nicosang
force-pushed
the
controllers_creation_modifications
branch
3 times, most recently
from
1a57ff6
to
fda3b5a
Compare
nicosang
force-pushed
the
controllers_creation_modifications
branch
from
f129773
to
a7cdaca
Compare
jeremco
force-pushed
the
controllers_creation_modifications
branch
2 times, most recently
from
a5cae5e
to
28c08e1
Compare
jeremco
force-pushed
the
controllers_creation_modifications
branch
from
28c08e1
to
3f8378a
Compare
…on events reception.
…t with BufferController.
… function in SourceBufferController.
…ereby, tests can be executed with a mock loader.
- Unformize the way PlaybackController and StreamController are instanciated - ManifestUpdater and EventController doesn't need to be singletons (getIsntance is called by only once controller for both classes)
- Update StreamProcessor creation : attributes are now passed in config and not in initialize methods -> uniformize with other attributes - Rename AbrController initialize method, because it is not a initialization but a registration
- Stream Processor - change the way controllers are created: the parameters are passed in create method, not in initialize method
…ream is read, move getInstance call in initialize method.
…re given to others controllers
jeremco
force-pushed
the
controllers_creation_modifications
branch
from
3f8378a
to
3873ff3
Compare
|
@AkamaiDASH could you, please, give us your feedback on this big PR? ;-) |
|
It is way too large for me to review and have any meaning. If you are willing to repair any broken references, if any, and support the large PR from regression I do not have any issue. Seems like changing stuff for consistency so that is great. |
dsparacio
approved these changes
Jun 19, 2017
| @@ -36,7 +36,7 @@ describe("RepresentationController", function () { | |||
| manifestModel.setValue(mpd); | |||
|
|
|||
| const abrController = AbrController(context).getInstance(); | |||
| abrController.registerStreamProcessor(testType, streamProcessor); | |||
| abrController.registerStreamType(testType, streamProcessor); | |||
There was a problem hiding this comment.
Not sure I agree with this naming. What is your justification?
spiterikevin
added a commit
to spiterikevin/dash.js
that referenced
this pull request
Jul 7, 2017
dsparacio
pushed a commit
that referenced
this pull request
Jul 10, 2017
fix abandonment in AbrController (broken since #1871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
The goal of this PR is to propose some changes in controllers creation sequences.
Some classes declared as singleton are now base classes (ManifestUpdater and EventController), because they don't need to be singletons (owned only by one class).
I have made some changes in streamProcessor in creation of buffer and schedule controller, to standardize the creation
Jérémie