-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controllers creation modifications #1871
Controllers creation modifications #1871
Conversation
f07f680
to
9ddaebd
Compare
421de0e
to
6c7e4d1
Compare
0934758
to
f3fc83d
Compare
015e175
to
9056a9f
Compare
1a57ff6
to
fda3b5a
Compare
f129773
to
a7cdaca
Compare
a5cae5e
to
28c08e1
Compare
28c08e1
to
3f8378a
Compare
…on events reception.
…t with BufferController.
… function in SourceBufferController.
…ereby, tests can be executed with a mock loader.
- Unformize the way PlaybackController and StreamController are instanciated - ManifestUpdater and EventController doesn't need to be singletons (getIsntance is called by only once controller for both classes)
- Update StreamProcessor creation : attributes are now passed in config and not in initialize methods -> uniformize with other attributes - Rename AbrController initialize method, because it is not a initialization but a registration
- Stream Processor - change the way controllers are created: the parameters are passed in create method, not in initialize method
…ream is read, move getInstance call in initialize method.
…re given to others controllers
3f8378a
to
3873ff3
Compare
@AkamaiDASH could you, please, give us your feedback on this big PR? ;-) |
It is way too large for me to review and have any meaning. If you are willing to repair any broken references, if any, and support the large PR from regression I do not have any issue. Seems like changing stuff for consistency so that is great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is way too large for me to review and have any meaning. If you are willing to repair any broken references, if any, and support the large PR from regression I do not have any issue. Seems like changing stuff for consistency so that is great.
@@ -36,7 +36,7 @@ describe("RepresentationController", function () { | |||
manifestModel.setValue(mpd); | |||
|
|||
const abrController = AbrController(context).getInstance(); | |||
abrController.registerStreamProcessor(testType, streamProcessor); | |||
abrController.registerStreamType(testType, streamProcessor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I agree with this naming. What is your justification?
fix abandonment in AbrController (broken since #1871)
Hello
The goal of this PR is to propose some changes in controllers creation sequences.
Some classes declared as singleton are now base classes (ManifestUpdater and EventController), because they don't need to be singletons (owned only by one class).
I have made some changes in streamProcessor in creation of buffer and schedule controller, to standardize the creation
Jérémie