Abr AbrController accessors #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ABR as a reference of RulesContext (rulesContext is created by ABRController, so why getting ABRController from streamProcessor ?) - Add an accessor to media type in RulesContext
- StreamProcessor : Remove useless getABRController method - BufferLevelRule : give ABRController isntance at creation of bufferLevelRule in scheduleController
jeremco
force-pushed
the
ABR_ABRController_Accessors
branch
from
8736857
to
09e60bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
The goal of this PR is to simplify access to ABRController from ABR and scheduling rules and to remove getABRController from streamController (this is not the role of the SP to give AbrController instance)
Jérémie